DM-53177 : Allow 8-char object IDs with backwards compatibility #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erinleighh
approved these changes
Nov 10, 2025
Contributor
erinleighh
left a comment
erinleighh
left a comment
There was a problem hiding this comment.
Looks good! Just some minor docstring changes. (Let's see if I did the multi-line review on Github correctly!)
| Raises | ||
| ------ | ||
| ValueError | ||
| Raised if either objID is longer than 7 characters or flags is greater |
Contributor
There was a problem hiding this comment.
Suggested change
| Raised if either objID is longer than 7 characters or flags is greater | |
| Raised if either objID is shorter than 7 or longer than 8 characters or contains |
| ------ | ||
| ValueError | ||
| Raised if either objID is longer than 7 characters or flags is greater | ||
| than 255 or less than 0. |
Contributor
There was a problem hiding this comment.
Suggested change
| than 255 or less than 0. | |
| illegal objID characters. |
Comment on lines
207
to
210
| flags : `int`, optional | ||
| Eight free bits to enable future decoupling between Minor Planet Center | ||
| and Rubin. Zero by default, should not be changed unless we need to | ||
| move away from a 1:1 mapping with the MPC. Must be within [0, 255]. |
Comment on lines
251
to
253
| flags : `int` | ||
| Rubin flags (not yet defined, but usable in case we decouple from MPC). | ||
Gerenjie
force-pushed
the
tickets/DM-53177
branch
3 times, most recently
from
5d37dae to
6701121
Compare
Gerenjie
force-pushed
the
tickets/DM-53177
branch
from
6701121 to
567f6d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.