DM-53344: Always return astropy tables from solar system association #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmsaunders
approved these changes
Nov 19, 2025
Contributor
cmsaunders
left a comment
cmsaunders
left a comment
There was a problem hiding this comment.
Was ssoAssocResult.unAssocDiaSources originally a DataFrame? This looks fine, but I'm wondering why there was a workaround before that seems to no longer be necessary.
Contributor
Author
In DM-53094 I moved this code into a class method, and standardized on using Astropy tables throughout. But I missed this edge case where the table was completely empty, and it wasn't caught until we ran with a lot of visits. It only triggers if the input diaSource catalog is not empty, but then every diaSource is associated with an asteroid. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.