Skip to content

Conversation

shenmingfu
Copy link
Contributor

Added methods: zooming and displaying frames side by side.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@MelissaGraham MelissaGraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shenming, my review is available as #81. The new sections didn't fit very well with what was already there, so I rearranged it to work with the established flow of the notebook. This required some changes to the screenshot but otherwise it's pretty much the same content.

For the FireflyClient I added how this is basically an instance of the Portal and linked to the Portal resources.

Once you merge my PR 81 into your branch, make any final tweaks in your branch (and do a final flake8 check), so long as the checks on your PR 79 are passing you're OK to merge. If there are any new issues just let me know.

u/mlg/2025-09-30/SP-2381-review: revise the order
@shenmingfu
Copy link
Contributor Author

Thank you so much Melissa! I've merged your PR 81 into my branch.

@shenmingfu
Copy link
Contributor Author

Final tweaks and the final flake8 check were done. Ready to merge.

@shenmingfu shenmingfu merged commit c0e802e into main Oct 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants