Skip to content

DM-51401: Ensure subTest arguments are strings. #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

DM-51401: Ensure subTest arguments are strings. #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/lsst/utils/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,7 +1014,7 @@ def decorator(func: Callable) -> Callable:
def wrapper(self: unittest.TestCase, *args: Any, **kwargs: Any) -> None:
for params in _settingsIterator(settings):
kwargs.update(params)
with self.subTest(**params):
with self.subTest(**{k: repr(v) for k, v in params.items()}):
func(self, *args, **kwargs)

return wrapper
Expand Down
2 changes: 1 addition & 1 deletion tests/test_timer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ def testTaskLike(self):

duration = 0.1
for log, metadata in parameters:
with self.subTest(log=log, metadata=metadata):
with self.subTest(log=repr(log), metadata=repr(metadata)):
task = Example1(log=log, metadata=metadata)
self.assertTimer(duration, task)
exampleDuration = duration_from_timeMethod(task.metadata, "sleeper")
Expand Down
Loading