Skip to content

Conversation

@timj
Copy link
Member

@timj timj commented Oct 28, 2025

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.61%. Comparing base (4397d32) to head (42c19ac).
⚠️ Report is 6 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   94.61%   94.61%           
=======================================
  Files          51       51           
  Lines        3880     3883    +3     
=======================================
+ Hits         3671     3674    +3     
  Misses        209      209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj timj force-pushed the tickets/DM-53079 branch from fb0e369 to 60c050c Compare October 28, 2025 22:20
@timj timj requested a review from dhirving October 29, 2025 14:56
@timj
Copy link
Member Author

timj commented Oct 29, 2025

@dhirving I'm changing lots of packages but they are all the same changes so if you could review just this PR that would be great and we don't need reviews on all the others.

Copy link
Contributor

@dhirving dhirving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@timj timj merged commit ed10c03 into main Oct 29, 2025
23 checks passed
@timj timj deleted the tickets/DM-53079 branch October 29, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants