Removed compare-versions dependency. #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated name handler function logic. There was really no need for in depth checking. The function simply should require a name for the function. Updated test to no longer look for node version error message.
|
Looks good. Thanks! 👌 |
Repository owner
deleted a comment from
nab911
Oct 2, 2017
|
Regarding deleted comment, I tried to hack the resolve comment to see if it would pick it up to close the issue. I guess it needs to be exactly in the PR body if not in the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated name handler function logic. There was really no need for in depth checking. The function simply should require a name for the function.
Updated test to no longer look for node version error message.
This resolves issue #6