#14 add typings on sjs module #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.d.ts
Outdated
| * compile the provided schema and exports a function | ||
| * that serialize objects enforcing the schema. | ||
| */ | ||
| export function sjs(schema: SjsSchema): SjsEscaper; |
There was a problem hiding this comment.
Typo line 77 it should be:
export function sjs(schema: SjsSchema): SjsSerializer;
index.d.ts
Outdated
| * | ||
| * Serialize any object enforcing the provided schema. | ||
| */ | ||
| export type SjsSerializer = (obj: object) => string; |
There was a problem hiding this comment.
It would be better to use unknown here instead of object.
export type SjsSerializer = (obj: unknown) => string;
Owner
Author
|
@markmcdowell Thanks for your review! Change has been merged and published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.