Fixing unexecuted validators in subcommand

Author: lucocozz

CHANGELOG.md

@@ -18,6 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 - Disabled pedantic option on library compilation.
 - Defining `argus_init()` as a `static inline` function.
+- Fixed unexecuted validators in subcommand.
 
 ### Removed
 - Group description option.

source/core/parsing/post_parse_validation.c

@@ -47,9 +47,8 @@ static int validate_conflicts(argus_t *argus, argus_option_t *options, argus_opt
 
 static int call_validators(argus_t *argus, argus_option_t *option)
 {
-    if (!option->validators) {
+    if (!option->validators)
         return ARGUS_SUCCESS;
-    }
 
     for (size_t i = 0; option->validators[i] != NULL; ++i) {
         validator_entry_t *validator = option->validators[i];
@@ -122,5 +121,12 @@ int post_parse_validation(argus_t *argus)
     if (status != ARGUS_SUCCESS)
         return status;
 
+    for (size_t i = 0; i < argus->subcommand_depth; ++i) {
+        const argus_option_t *subcommand = argus->subcommand_stack[i];
+        status = validate_options_set(argus, (argus_option_t *)subcommand->sub_options);
+        if (status != ARGUS_SUCCESS)
+            return (status);
+    }
+
     return status;
 }

tests/integration/test_subcommand_edge_case.c

@@ -19,7 +19,7 @@ ARGUS_OPTIONS(
     foo_options,
     HELP_OPTION(),
     OPTION_FLAG('v', "verbose", HELP("Enable verbose output")),
-    POSITIONAL_INT("value", HELP("A numerical value")),
+    POSITIONAL_INT("value", HELP("A numerical value"), VALIDATOR(V_RANGE(-50, 50))),
 )
 
 ARGUS_OPTIONS(
@@ -238,6 +238,21 @@ Test(subcommand_edge, subcommand_negative_number, .init = setup_subcommand)
     argus_free(&argus);
 }
 
+// Test Validator invalid value in subcommands
+Test(subcommand_edge, subcommand_invalid_value, .init = setup_subcommand)
+{
+    char *argv[] = {"test", "nested", "foo", "100"};
+    int argc = sizeof(argv) / sizeof(char *);
+    
+    argus_t argus = argus_init(cmd_options, "test", "1.0.0");
+    int status = argus_parse(&argus, argc, argv);
+    
+    cr_assert_neq(status, ARGUS_SUCCESS, "Subcommand with invalid number should fail");
+    cr_assert(argus_has_command(&argus), "argus_has_command should return true");
+
+    argus_free(&argus);
+}
+
 // Helper function for format tests
 void setup_error_redirect(void)
 {