Test enable hdf feature virtual workspace

.github/workflows/CI.yml

@@ -17,6 +17,8 @@ env:
   RUSTDOCFLAGS: -D warnings
   RUST_BACKTRACE: 1
   RUST_LOG: debug
+  JUST_VERBOSE: 1
+  JUST_COLOR: always
 
 jobs:
   check:
@@ -42,6 +44,7 @@ jobs:
         with:
           targets: ${{matrix.TARGET}}
       - uses: Swatinem/rust-cache@v2
+      - run: sudo apt-get update && sudo apt-get install libhdf5-dev
       - run: cargo check ${{matrix.flags}} --target ${{matrix.TARGET}}
 
   audit:
@@ -70,8 +73,22 @@ jobs:
       - uses: actions/checkout@v4
       - uses: dtolnay/rust-toolchain@stable
       - uses: taiki-e/install-action@nextest
+      - uses: extractions/setup-just@v2
       - uses: Swatinem/rust-cache@v2
-      - run: cargo nextest run --workspace --profile ci
+
+      - name: Install HDF5
+        shell: bash
+        run: just init::install-hdf5-headers
+
+      - name: Run MSI installer (windows)
+        if: runner.os == 'Windows'
+        shell: pwsh
+        run: |
+          cd just\hdf
+          msiexec /i HDF5-1.14.0-win64.msi /quiet /qn /norestart
+
+      - name: Run tests
+        run: cargo nextest run --workspace --profile ci
 
   format:
     runs-on: ubuntu-latest
@@ -91,6 +108,7 @@ jobs:
         with:
           components: clippy
       - uses: Swatinem/rust-cache@v2
+      - run: sudo apt-get update && sudo apt-get install libhdf5-dev
       - name: Lint native
         run: cargo clippy --workspace --all-features -- -D warnings -W clippy::all
       - name: Lint WASM
@@ -112,84 +130,8 @@ jobs:
       - name: Build
         run: ./trunk build
 
-  build:
-    runs-on: ${{ matrix.os }}
-    strategy:
-      fail-fast: false
-      matrix:
-        include:
-          - os: macos-latest
-            # macos-latest seems to already run on arm64(=aarch64):
-            # https://docs.github.com/en/actions/using-jobs/choosing-the-runner-for-a-job#standard-github-hosted-runners-for-public-repositories
-            TARGET: aarch64-apple-darwin
-
-          - os: macos-13
-            TARGET: x86_64-apple-darwin
-            # even though the runner uses arm64, MacOS on arm64 seems to support building for amd64.
-            # which makes sense, would be bad for devs otherwise.
-            cross: false
-
-          - os: ubuntu-latest
-            TARGET: aarch64-unknown-linux-gnu
-            cross: true
-
-          - os: ubuntu-latest
-            TARGET: armv7-unknown-linux-gnueabihf
-            cross: true
-
-          - os: ubuntu-latest
-            TARGET: x86_64-unknown-linux-gnu
-
-          - os: windows-latest
-            TARGET: x86_64-pc-windows-msvc
-            EXTENSION: .exe
-
-    steps:
-      - name: Install cross
-        # Github doesnt have runners with exotic architectures (eg. arm64/aarch64 on anything but macos).
-        # Thus we use cross.
-        # It's necessary to use an up-to-date cross from the git repository to avoid glibc problems on linux
-        # Ref: https://github.com/cross-rs/cross/issues/1510
-        if: matrix.cross
-        run: |
-          echo "Resetting RUSTFLAGS as a temporary fix for: https://github.com/cross-rs/cross/issues/1561"
-          RUSTFLAGS="" cargo install cross --git https://github.com/cross-rs/cross --rev 1b8cf50d20180c1a394099e608141480f934b7f7
-
-      - name: Building ${{ matrix.TARGET }}
-        run: echo "${{ matrix.TARGET }}"
-
-      - uses: actions/checkout@master
-
-      - uses: dtolnay/rust-toolchain@stable
-        with:
-          targets: ${{ matrix.TARGET }}
-
-      - uses: Swatinem/rust-cache@v2
-        with:
-          # this is required to avoid failures due to caching of artifacts for different architectures
-          # The reason is the potential usage of cross.
-          # The cache checks the rustc host which doesn't record us targeting
-          # different architectures (and native) with cross on the generic ubuntu-latest.
-          key: ${{ matrix.TARGET }}
-
-      - if: ${{ !matrix.cross }}
-        name: Cargo Build
-        run: cargo build --verbose --release --target=${{ matrix.TARGET }}
-
-      - if: matrix.cross
-        name: Cross Build
-        run: cross build --verbose --release --target=${{ matrix.TARGET }}
-
-      - name: Rename
-        run: cp target/${{ matrix.TARGET }}/release/${{ github.event.repository.name }}${{ matrix.EXTENSION }} ${{ github.event.repository.name }}-${{ matrix.TARGET }}${{ matrix.EXTENSION }}
-
-      - uses: actions/upload-artifact@master
-        with:
-          name: ${{ github.event.repository.name }}-${{ matrix.TARGET }}${{ matrix.EXTENSION }}
-          path: ${{ github.event.repository.name }}-${{ matrix.TARGET }}${{ matrix.EXTENSION }}
-
   tag-release:
-    needs: [check, audit, test, format, lint, trunk, build]
+    needs: [check, audit, test, format, lint, trunk]
     runs-on: ubuntu-latest
     if: github.ref == 'refs/heads/master' && success()
     permissions:

.github/workflows/build-setup.yml

@@ -0,0 +1,12 @@
+- name: Install Just
+  uses: extractions/setup-just@v2
+- name: Install HDF5
+  shell: bash
+  run: just init::install-hdf5-headers
+
+- name: Run MSI installer (windows)
+  if: runner.os == 'Windows'
+  shell: pwsh
+  run: |
+    cd just\hdf
+    msiexec /i HDF5-1.14.0-win64.msi /quiet /qn /norestart

.github/workflows/release.yml

@@ -125,6 +125,17 @@ jobs:
             curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
             echo "$HOME/.cargo/bin" >> $GITHUB_PATH
           fi
+      - name: "Install Just"
+        uses: "extractions/setup-just@v2"
+      - name: "Install HDF5"
+        run: "just init::install-hdf5-headers"
+        shell: "bash"
+      - name: "Run MSI installer (windows)"
+        if: "runner.os == 'Windows'"
+        run: |
+          cd just\hdf
+          msiexec /i HDF5-1.14.0-win64.msi /quiet /qn /norestart
+        shell: "pwsh"
       - uses: swatinem/rust-cache@v2
         with:
           key: ${{ join(matrix.targets, '-') }}

Cargo.toml

@@ -1,27 +1,35 @@
-[package]
-name = "plotinator3000"
-description = "Log viewer app for viewing plots of data from projects such as motor and generator control"
-authors = ["SkyTEM Surveys", "Marc Beck König"]
+[workspace]
+members = ["crates/*"]
+resolver = "2"
+
+[workspace.package]
 version = "1.6.4"
+authors = ["SkyTEM Surveys", "Marc Beck König"]
 edition = "2021"
-repository = "https://github.com/luftkode/plotinator3000"
-homepage = "https://github.com/luftkode/plotinator3000"
 license = "MIT OR Apache-2.0"
-
-[package.metadata.wix]
-upgrade-guid = "7063C05B-24FE-4CE5-A338-6D750F3F10CE"
-path-guid = "025605DB-83DB-4162-B505-26B36C02D0B9"
-license = false
-eula = false
-product-icon = "assets/favicon.ico"
-
-
-[workspace]
-members = ["crates/*"]
+description = "Log viewer app for viewing plots of data from projects such as motor and generator control"
+homepage = "https://github.com/luftkode/plotinator3000"
+repository = "https://github.com/luftkode/plotinator3000"
 
 [workspace.dependencies]
+plotinator-lib = { version = "*", path = "crates/plotinator-lib" }
+skytem_logs = { version = "*", path = "crates/skytem_logs" }
+log_if = { version = "*", path = "crates/log_if" }
+plot_util = { version = "*", path = "crates/plot_util" }
+skytem_hdf = { version = "*", path = "crates/skytem_hdf" }
+eframe = { version = "0.30", default-features = false, features = [
+    "default_fonts", # Embed the default egui fonts.
+    "glow",          # Use the glow rendering backend. Alternative: "wgpu".
+    "persistence",   # Enable restoring app state when restarting the app.
+    "wayland",
+    "x11"
+] }
 egui = { version = "0.30", features = ["rayon"] }
 egui_plot = { version = "0.30", features = ["serde"] }
+rfd = "0.15"
+egui-phosphor = "0.8.0"
+egui-notify = "0.18.0"
+tokio = "1.43.0"
 log = "0.4"
 serde = { version = "1", features = ["derive"] }
 serde-big-array = "0.5.1"
@@ -43,58 +51,6 @@ pretty_assertions = "1.4.1"
 tempfile = "3.15.0"
 reqwest = "0.12.12"
 
-[dependencies]
-skytem_logs = { version = "*", path = "crates/skytem_logs" }
-log_if = { version = "*", path = "crates/log_if" }
-plot_util = { version = "*", path = "crates/plot_util" }
-skytem_hdf = { version = "*", path = "crates/skytem_hdf" }
-egui_plot.workspace = true
-log.workspace = true
-serde.workspace = true
-strum.workspace = true
-strum_macros.workspace = true
-chrono.workspace = true
-getset.workspace = true
-semver.workspace = true
-egui.workspace = true
-eframe = { version = "0.30", default-features = false, features = [
-    "default_fonts", # Embed the default egui fonts.
-    "glow",          # Use the glow rendering backend. Alternative: "wgpu".
-    "persistence",   # Enable restoring app state when restarting the app.
-    "wayland",
-    "x11"
-] }
-rfd = "0.15"
-egui-phosphor = "0.8.0"
-egui-notify = "0.18.0"
-tokio = "1.43.0"
-
-[dev-dependencies]
-testresult.workspace = true
-tempfile.workspace = true
-reqwest.workspace = true
-
-[features]
-default = ["selfupdater"]
-hdf = []
-selfupdater = []
-
-# native:
-[target.'cfg(not(target_arch = "wasm32"))'.dependencies]
-env_logger = "0.11"
-zip = "2.2.2"
-axoupdater = { version = "0.9.0", features = ["blocking"] }
-
-
-# web:
-[target.'cfg(target_arch = "wasm32")'.dependencies]
-wasm-bindgen-futures = "0.4"
-web-sys = "0.3.70"
-
-# windows
-[target.'cfg(target_os = "windows")'.dependencies]
-elevated-command.workspace = true
-
 [profile.release]
 opt-level = 3
 debug = false
@@ -111,9 +67,6 @@ opt-level = 2
 [profile.dist]
 inherits = "release"
 
-[lints]
-workspace = true
-
 [workspace.lints.rust]
 missing_debug_implementations = "warn"
 missing_copy_implementations = "warn"