Skip to content

Conversation

@CramBL
Copy link
Contributor

@CramBL CramBL commented May 10, 2025

PR Type

  • πŸ’° Feature
  • πŸͺ² Bug Fix
  • πŸ‘·β€β™€οΈ Refactor
  • πŸ“– Documentation Update

Description

Builds on top of #236

Resolves #233

Checklist

  • 🌞 Changelog updated

@CramBL
Copy link
Contributor Author

CramBL commented May 12, 2025

Skip the snapshot part of tests on windows and linux runners if CI=true. They should still be able to run the GUI code that doesn't actually render the graphics.

@CramBL CramBL force-pushed the dev-mqtt branch 2 times, most recently from a00508c to c5921a3 Compare May 14, 2025 08:35
@CramBL CramBL requested a review from andcor May 14, 2025 10:29
@CramBL CramBL marked this pull request as ready for review May 14, 2025 10:29
Copy link
Contributor

@andcor andcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parts I understood looked fine, but a single comment

@CramBL CramBL enabled auto-merge (squash) May 19, 2025 09:33
Copy link
Contributor

@andcor andcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A nice fix for the boolean flag not being able to take on three different values. Much clearer

@CramBL CramBL merged commit bffef02 into master May 20, 2025
29 checks passed
@CramBL CramBL deleted the dev-mqtt branch May 20, 2025 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use mimalloc as standard allocator

2 participants