-
Couldn't load subscription status.
- Fork 0
MQTT qol #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skip the snapshot part of tests on windows and linux runners if CI=true. They should still be able to run the GUI code that doesn't actually render the graphics. |
a00508c to
c5921a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parts I understood looked fine, but a single comment
β¦ of broker validation is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A nice fix for the boolean flag not being able to take on three different values. Much clearer
PR Type
Description
Builds on top of #236
Resolves #233
Checklist