Support SEO friendly meta tags #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm using this patch and it works wonderfully! |
luizdepra
reviewed
Apr 26, 2020
layouts/_default/baseof.html
Outdated
| {{ with .Site.Params.description }}<meta name="description" content="{{ . }}">{{ end }} | ||
| {{ with .Site.Params.keywords }}<meta name="keywords" content="{{ . }}">{{ end }} | ||
| <meta name="description" content="{{ with .Description }}{{ . }}{{ else }}{{ if .IsPage }}{{ with .Params.description }}{{ . }}{{ else }}{{ .Summary }}{{ end }}{{ else }}{{ .Site.Params.description }}{{ end }}{{ end }}"> | ||
| <meta name="keywords" content="{{ with .Keywords }}{{ delimit . "," }}{{ else }}{{ if .IsPage }}{{ with .Params.keywords }}{{ delimit . "," }}{{ else }}{{ .Site.Params.keywords }}{{ end }}{{ else }}{{ .Site.Params.keywords }}{{ end }}{{ end }}"> |
There was a problem hiding this comment.
I think we can simplify this part using chained defaults. Something like this:
<meta name="description" content="{{ .Description | default (.Summary | default .Site.Params.description ) }}">
<meta name="keywords" content="{{ (delimit .Keywords ",") | default .Site.Params.keywords }}">
There was a problem hiding this comment.
You are right 👍, and I have simplified it now
|
Thanks. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Put an
xinto the box(es) that apply:Description
Support two SEO friendly tags:
<meta name="description">and<meta name="keywords">.Because of the following code snippet, the meta tag
<meta name="description">and<meta name="keywords">on the website will use the Hugo site variables on every page, and that is actually not SEO friendly.hugo-coder/layouts/_default/baseof.html
Lines 9 to 10 in acb4bf6
I have rewritten this code snippet, and hope to use such a strategy:
{{ with .Description }} <meta name="description" content="{{ . }}"> {{ else }} {{ if .IsPage }} {{ with .Params.description }} <meta name="description" content="{{ . }}"> {{ else }} <meta name="description" content="{{ .Summary }}"> {{ end }} {{ else }} <meta name="description" content="{{ .Site.Params.description }}"> {{ end }} {{ end }} {{ with .Keywords }} <meta name="keywords" content="{{ delimit . "," }}"> {{ else }} {{ if .IsPage }} {{ with .Params.keywords }} <meta name="keywords" content="{{ delimit . "," }}"> {{ else }} <meta name="keywords" content="{{ .Site.Params.keywords }}"> {{ end }} {{ else }} <meta name="keywords" content="{{ .Site.Params.keywords }}"> {{ end }} {{ end }}Issues Resolved
#299
Checklist
Put an
xinto the box(es) that apply:General
#<ISSUE_NO>if applicableResources
make releaseto regenerate all CSS filesContributors
CONTRIBUTORS.mdif you aren't on it already