Merge refactor/service-weak-references into staging #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Kitt3120
added a commit
that referenced
this pull request
Oct 5, 2024
* add: Cargo.lock file * Update dependabot.yml * Merge refactor/service-weak-references into staging (#58) refactor: use Weak instead of Arc self-references * Merge refactor/once-cell into staging (#62) refactor: use OnceLock instead of SetLock - Use OnceLock where SetLock was previously used - Remove SetLock * Merge refactor/async into staging (#63) refactor: use async_trait where possible * Merge feature/cargo-optimizations into staging (#64) add: Cargo.toml settings * fix: bump version to 0.3.0
Kitt3120
added a commit
that referenced
this pull request
Oct 5, 2024
* add: Cargo.lock file * Update dependabot.yml * Merge refactor/service-weak-references into staging (#58) refactor: use Weak instead of Arc self-references * Merge refactor/once-cell into staging (#62) refactor: use OnceLock instead of SetLock - Use OnceLock where SetLock was previously used - Remove SetLock * Merge refactor/async into staging (#63) refactor: use async_trait where possible * Merge feature/cargo-optimizations into staging (#64) add: Cargo.toml settings * fix: bump version to 0.3.0 * fix: cartes.io publishing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several significant changes to the
EventRepeaterandServiceManagercomponents, focusing on replacingArcwithWeakreferences to prevent potential memory leaks and improve error handling. The most important changes include updating the initialization logic and error handling mechanisms.EventRepeater Improvements:
src/event/event_repeater.rs: Replacedself_arcwithweakto useWeakreferences for self-referencing, and added error handling for setting and upgradingWeakreferences. [1] [2] [3] [4] [5]ServiceManager Enhancements:
src/service/service_manager.rs: Updated theServiceManagerto useWeakreferences instead ofArcfor self-referencing, and added error handling for setting and upgradingWeakreferences. [1] [2] [3]