Skip to content

Conversation

@saartochner-lumigo
Copy link
Contributor

@saartochner-lumigo saartochner-lumigo commented Aug 18, 2020

for original handler:
image
with a.py: import time; time.sleep(5)

Before change:
image

After change:
image

I.e. we moved the initialization to be in the initialization (As it would have happened if we wouldn't be there)

@saartochner-lumigo saartochner-lumigo changed the title RD-3263 - auto-instrument: import the user handler during import RD-3263 - auto-instrument: fast handler import Aug 19, 2020
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #142 into master will decrease coverage by 0.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   96.21%   95.81%   -0.41%     
==========================================
  Files          11       11              
  Lines         952     1147     +195     
==========================================
+ Hits          916     1099     +183     
- Misses         36       48      +12     
Impacted Files Coverage Δ
lumigo_tracer/utils.py 88.72% <0.00%> (-1.33%) ⬇️
lumigo_tracer/sync_http/sync_hook.py 98.42% <0.00%> (-0.97%) ⬇️
lumigo_tracer/parsers/parser.py 100.00% <0.00%> (ø)
lumigo_tracer/parsers/http_data_classes.py 100.00% <0.00%> (ø)
lumigo_tracer/parsers/event_parser.py 97.70% <0.00%> (+0.02%) ⬆️
lumigo_tracer/spans_container.py 99.44% <0.00%> (+0.07%) ⬆️
lumigo_tracer/parsers/utils.py 94.91% <0.00%> (+1.25%) ⬆️
lumigo_tracer/sync_http/handler.py 100.00% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8155956...1e47f56. Read the comment docs.

@saartochner-lumigo saartochner-lumigo merged commit fd4d37f into master Aug 19, 2020
@saartochner-lumigo saartochner-lumigo deleted the RD-3263-import-during-runtime-initialization branch August 19, 2020 07:56
saartochner-lumigo pushed a commit that referenced this pull request Aug 19, 2020
…handler during import (#142)

8155956 layers-table: layers md [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants