Skip to content

Conversation

@saartochner-lumigo
Copy link
Contributor

No description provided.

saartochner-lumigo and others added 28 commits October 4, 2020 17:13
…acer into RD-3690-redis-sqlalchemy-elasticsearch
Base automatically changed from RD-3761-wrap-pymongo to master October 19, 2020 15:07
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #154 into master will increase coverage by 2.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   96.21%   98.25%   +2.03%     
==========================================
  Files          11       21      +10     
  Lines         952     1544     +592     
==========================================
+ Hits          916     1517     +601     
+ Misses         36       27       -9     
Impacted Files Coverage Δ
lumigo_tracer/sync_http/sync_hook.py
lumigo_tracer/sync_http/handler.py
lumigo_tracer/utils.py
lumigo_tracer/parsers/parser.py
lumigo_tracer/parsers/event_parser.py
lumigo_tracer/parsers/utils.py
lumigo_tracer/parsers/http_data_classes.py
lumigo_tracer/auto_instrument_handler.py 100.00% <0.00%> (ø)
lumigo_tracer/wrappers/__init__.py 100.00% <0.00%> (ø)
lumigo_tracer/extension/sampler.py 100.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39de956...009afa1. Read the comment docs.

Copy link
Contributor

@nirLumigo nirLumigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :)

def execute_wrapper(func, instance, args, kwargs):
with lumigo_safe_execute("redis start"):
commands = instance.command_stack
command = [cmd[0] for cmd in commands if cmd] or None
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, the value here might be both list or None, is this ok?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here yes :-)

@saartochner-lumigo saartochner-lumigo merged commit a26fdac into master Oct 20, 2020
@saartochner-lumigo saartochner-lumigo deleted the RD-3762-redis branch October 20, 2020 10:50
saartochner-lumigo pushed a commit that referenced this pull request Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants