Skip to content

Fix domains-scrubber #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2021
Merged

Fix domains-scrubber #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/lumigo_tracer/lumigo_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
import inspect
import traceback

LUMIGO_DOMAINS_SCRUBBER_KEY = "LUMIGO_DOMAINS_SCRUBBER"

try:
import botocore
import boto3
Expand Down Expand Up @@ -182,9 +184,9 @@ def config(
Configuration.send_only_if_error = os.environ.get("SEND_ONLY_IF_ERROR", "").lower() == "true"
if domains_scrubber:
domains_scrubber_regex = domains_scrubber
elif "LUMIGO_DOMAINS_SCRUBBER" in os.environ:
elif LUMIGO_DOMAINS_SCRUBBER_KEY in os.environ:
try:
domains_scrubber_regex = json.loads(os.environ["LUMIGO_DOMAIN_SCRUBBER"])
domains_scrubber_regex = json.loads(os.environ[LUMIGO_DOMAINS_SCRUBBER_KEY])
except Exception:
get_logger().critical(
"Could not parse the specified domains scrubber, shutting down the reporter."
Expand Down
6 changes: 6 additions & 0 deletions src/test/unit/test_lumigo_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,6 +390,12 @@ def test_config_enhanced_printstep_function_without_envs(monkeypatch, configurat
assert Configuration.is_step_function == configuration_value


def test_config_lumigo_domains_scrubber_with_envs(monkeypatch):
monkeypatch.setenv("LUMIGO_DOMAINS_SCRUBBER", '["lambda.us-west-2.amazonaws.com"]')
config()
assert len(Configuration.domains_scrubber) == 1


def test_config_timeout_timer_buffer_with_exception(monkeypatch):
monkeypatch.setenv("LUMIGO_TIMEOUT_BUFFER", "not float")
config()
Expand Down