find s3 bucket name from uri (and not just from host) #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 96.21% 97.50% +1.28%
==========================================
Files 11 22 +11
Lines 952 1800 +848
==========================================
+ Hits 916 1755 +839
- Misses 36 45 +9
Continue to review full report at Codecov.
|
add tests to all cases
add tests to all cases
nirLumigo
suggested changes
Apr 13, 2021
| elif service == "events": | ||
| return EventBridgeParser | ||
| elif safe_split_get(url, ".", 1) == "s3": | ||
| elif safe_split_get(url, ".", 1) == "s3" or safe_split_get(url, ".", 0) == "s3": |
Contributor
There was a problem hiding this comment.
Add a test for this so no one will accidentally break it
nirLumigo
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.