Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
# 3.0.6
- `--tag` option is optional while bootstrapping if you already have a configured `task_definition`

# 3.0.5
- Make `update_service` work correctly for services configured with load balancers

# 3.0.4
- `--tag` option required during bootstrapping

# 3.0.3
- update of GLI specifications, adding on to 3.0.2

Expand Down
1 change: 1 addition & 0 deletions lib/broadside/ecs/ecs_deploy.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ def bootstrap
info "Task definition for #{family} already exists."
else
raise ConfigurationError, "No :task_definition_config for #{family}" unless @target.task_definition_config
raise ConfigurationError, 'Bootstrapping a task_definition requires a --tag option' unless @target.tag
info "Creating an initial task definition for '#{family}' from the config..."

EcsManager.ecs.register_task_definition(
Expand Down
5 changes: 4 additions & 1 deletion lib/broadside/gli/commands.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ def add_command_flags(cmd)

desc 'Bootstrap your service and task definition from the configured definition.'
command :bootstrap do |bootstrap|
add_tag_flag(bootstrap)
bootstrap.desc 'Optionally configured tag - without it you cannot bootstrap a task_definition'
bootstrap.arg_name 'TAG'
bootstrap.flag 'tag', :optional
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I'm not familiar with GLI; this is probably the best path.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess it was just this comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GLI is actually kind of amazing, honestly, though it's a little weird to wrap your head around at first

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep


add_target_flag(bootstrap)

bootstrap.action do |_, options, _|
Expand Down
2 changes: 1 addition & 1 deletion lib/broadside/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module Broadside
VERSION = '3.0.5'.freeze
VERSION = '3.0.6'.freeze
end