Give the super key a name distinct from the meta key #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! Good catch! I guess this does not break anything in the given examples in the course material - have you checked? |
Contributor
Author
|
There is no mention of "Meta" in any files in the workspace of provided code (outside the library itself). |
Member
|
OK great! |
Member
|
I was wondering about keeping the name "Windows" to conform with the Swing name? Pros / cons of "Windows" vs "Super"? The latter looks more nice but perhaps the deviation from Swing land is a problem? Not sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #54
I changed the name to
"Super", I can edit the PR it if a better name is decided upon.