加了卡spfa的图、支持了自定义边权生成器、修复了部分bug #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
我刚才看你上一个pr的iterate_edges方法，为什么要end>=start才yield？感觉这是一个bug，有向图加边又不会加两次，而且万一我就是要5到1那不就坏了 |
Contributor
Author
|
不是bug... or self.directed |
Contributor
Author
|
有向边是一定会yield的，无向边因为加两次所以只返回一次 |
Member
|
好像是这样没错 |
Contributor
Author
|
等下啊我再看看 |
Member
|
等一下，那还有一个问题，自环不就yield两次了？ |
Contributor
Author
|
自环没有yield两次，详见add_edge |
Member
|
唔 不过在这里有什么可能需要把无向图分开处理的地方吗 |
Contributor
Author
|
shuffle的时候有用吧...其他意义不大,.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rt.