Just created a 2.3.13 release

[lurcher]

Can people let me know what I have forgotten to do, there will be a lot given its 2 years since I last did this.

[jubalh]

With 2.3.13 I still get: #158

[   48s] yyparse.c: In function 'nnsql_yyparse':
[   48s] yyparse.y:38:33: error: implicit declaration of function 'nnsql_yylex'; did you mean 'nnsql_yyinit'? [-Wimplicit-function-declaration]
[   48s]    38 | # define yylex(pyylval)         nnsql_yylex(pyylval, pyyenv)
[   48s]       |                                 ^~~~~~~~~~~
[   48s] yyparse.c:1565:16: note: in expansion of macro 'yylex'
[   48s]  1565 |       yychar = yylex (&yylval);
[   48s]       |                ^~~~~

[jubalh]

fullog.txt

[jubalh]

d4782b9 fixed that but f709eea reintroduced it.

So readding int nnsql_yylex(union YYSTYPE* pyylval, yyenv_t* penv); fixes the build for me.

[lurcher]

Where did you add that prototype?

[jubalh]

In Drivers/nn/yyparse.y below union YYSTYPE; basically undoing what f709eea did in that particular file.

[jubalh]

@lurcher I can create a pull request if you want. Just let me know.

[lurcher]

On 29/09/2025 12:33, Michael Vetter wrote: *jubalh* left a comment (lurcher/unixODBC#219) <#219 (comment)> @lurcher <https://github.com/lurcher> I can create a pull request if you want. Just let me know.

Ok, But if we are undoing a previous change, at least one of you will be somewhere you don't want to be.

[lurcher]

On 29/09/2025 12:33, Michael Vetter wrote: *jubalh* left a comment (lurcher/unixODBC#219) <#219 (comment)> @lurcher <https://github.com/lurcher> I can create a pull request if you want. Just let me know.

I believe I have updated the release, see how that goes.

[jubalh]

I believe I have updated the release, see how that goes.

You should never update an existing release :)

The reason is that you don't know who already grapped your tarball at an earlier time. For example we at openSUSE already got your new tarball for the commit tagged 2.3.13. Now there will be a mismatch between the checksums compared to the newer tarball with the same name. Please always make new releases :)

[jubalh]

Ok, But if we are undoing a previous change, at least one of you will be
somewhere you don't want to be.

That's not correct :)
In d4782b9 someone added that line (to fix the build) and in f709eea you reverted that change (so your commit was the one that undid a previous change). And now we are just adding it back.

[jubalh]

I believe I have updated the release, see how that goes.

But it seems actually everything is fine. You just made a new commit and didn't change the tag, so everything is fine :)
Might be that later you just need to create a 2.3.14 to include that new commit in the new release.

Btw in 95f014f your now also change Drivers/nn/yyparse.c. But all I did was just changing the line I mentioned above.

[lurcher]

On 29/09/2025 15:07, Michael Vetter wrote: *jubalh* left a comment (lurcher/unixODBC#219) <#219 (comment)> I believe I have updated the release, see how that goes. But it seems actually everything is fine. You just made a new commit and didn't change the tag, so everything is fine :) Might be that later you just need to create a 2.3.14 to include that new commit in the new release. Btw in 95f014f <95f014f> your now also change Drivers/nn/yyparse.c. But all I did was just changing the line I mentioned above.

Yes, I removed yyparse.c as it was a file created by yacc/bison. Indeed. The problem is that once I create a release it gets tested, so all the problems appear after the release, not when they should before it.

[lurcher]

On 29/09/2025 15:10, Nick Gorham wrote: On 29/09/2025 15:07, Michael Vetter wrote: > *jubalh* left a comment (lurcher/unixODBC#219) > <#219 (comment)> > > I believe I have updated the release, see how that goes. > > But it seems actually everything is fine. You just made a new commit > and didn't change the tag, so everything is fine :) > Might be that later you just need to create a 2.3.14 to include that > new commit in the new release. > > Btw in 95f014f > <95f014f> > your now also change Drivers/nn/yyparse.c. But all I did was just > changing the line I mentioned above. > Yes, I removed yyparse.c as it was a file created by yacc/bison. Indeed. The problem is that once I create a release it gets tested, so all the problems appear after the release, not when they should before it.

Ok, there is a 2.3.14pre there now. Moving forward.

[jubalh]

Ok, there is a 2.3.14pre there now. Moving forward.

I just compiled it and it seems to work fine 👍

[esetnik]

@lurcher the release v2.3.13 is missing the binary asset uploaded on the release. In v2.3.12 we had the asset unixODBC-2.3.12.tar.gz