ci(lint): scan clang-tidy push-event delta, not full tree (ADR-0133)#71
Merged
ci(lint): scan clang-tidy push-event delta, not full tree (ADR-0133)#71
Conversation
The clang-tidy workflow's push branch walked git ls-files on the whole repo and tripped on long-latent warnings in vendored code (libsvm, libvmaf/src/cuda/*.c without CUDA headers) unrelated to the push. Unify both events under delta semantics so the job name matches its behaviour. fetch-depth: 0 added so the <before> SHA is locally reachable without a second fetch step. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
519cd0e to
08d4acc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pushandpull_requestevents — both now scan only the event's delta.push-event scan walkedgit ls-filesover the whole repo and tripped on long-latent warnings in vendoredlibvmaf/src/svm.cpp(libsvm) and CUDA sources compiled without CUDA headers (unrelated to the merged PR).actions/checkout@v6bumped tofetch-depth: 0so the<before>..HEADrange is locally reachable without a second fetch.Symptom addressed
actions/runs/24686615999/job/72197545195 failed on master after the PR #70 squash-merge landed. The PR itself passed clang-tidy (delta-scan). The push-event scan then processed every
.c/.cppin the tree, surfacingclang-analyzer-unix.Mallocinsvm.cpp:2984and aclang-diagnostic-errorcascade inlibvmaf/src/cuda/*.c(CUDA types unknown because the workflow sets up without CUDA).Test plan
Deep-dive deliverables (ADR-0108)
## Alternatives considered(four options: silence warnings, exclude paths, delta-scan chosen, drop push trigger)..github/workflows/lint-and-format.ymlis fork-only CI and does not live in an upstream-mirrored file..github/is fork-wins per/sync-upstreamconflict policy.Reproducer
🤖 Generated with Claude Code