Skip to content

docs(rebase-notes): Netflix#1486 motion updates verified present (ADR-0158)#95

Merged
lusoris merged 1 commit intomasterfrom
docs/netflix-1486-verified-present
Apr 24, 2026
Merged

docs(rebase-notes): Netflix#1486 motion updates verified present (ADR-0158)#95
lusoris merged 1 commit intomasterfrom
docs/netflix-1486-verified-present

Conversation

@lusoris
Copy link
Copy Markdown
Owner

@lusoris lusoris commented Apr 24, 2026

Summary

Verification pass confirmed that Netflix upstream PR #1486 "Port motion updates" (MERGED 2026-04-20) is already fully absorbed into the fork's master — not via a direct port PR but via earlier incremental motion3 / blend / five-frame-window / moving-average commits that landed separately.

Markers confirmed present in fork master:

  • edge_8 mirror fix i_tap = height - (i_tap - height + 2) at integer_motion.c:240, x86/motion_avx2.c:147, x86/motion_avx512.c:147.
  • motion_max_val option (default 10000.0, FEATURE_PARAM flag) at integer_motion.c:57,118-120.
  • VMAF_integer_feature_motion3_score output plumbing in integer_motion.c + alias.c.
  • All 73 coordinated Netflix golden assertAlmostEqual updates from upstream commit 62f47d5 present in fork's python test files.

Fork PR #45 (9371a0aa feat(libvmaf/feature): port upstream motion updates) tracked the 1:1 port attempt but never merged — its substance landed via fork-native work instead. End state is equivalent.

Scope

Doc-only close per user popup 2026-04-24 → "Doc-only PR":

No CHANGELOG entry — no user-visible delta.
No code changemeson test -C build → 35/35 (unchanged).

Test

  • `git status` after docs changes → only the 3 doc files modified.
  • `meson test -C build` → 35/35 pass (no delta vs master).
  • Pre-commit hooks green.

Type

  • `docs` — documentation

Netflix golden-data gate (ADR-0024)

  • Did not modify any `assertAlmostEqual` value. The 73 upstream-coordinated updates were already present in fork master before this PR.

Cross-backend numerical results

```text
N/A — zero code change; no numerical path touched.
```

Deep-dive deliverables (ADR-0108)

  • Research digest — no digest needed: verification of upstream PR presence is not a research question.
  • Decision matrix — ADR-0158 §Alternatives considered.
  • `AGENTS.md` invariant note — no rebase-sensitive invariants: this ADR exists precisely to note that Port motion updates Netflix/vmaf#1486 is absorbed, so no invariant survives that a rebase could drop.
  • Reproducer / smoke-test command — pasted below.
  • `CHANGELOG.md` "lusoris fork" entry — no changelog needed: no user-visible change.
  • Rebase note — entry 0051 in docs/rebase-notes.md.

Reproducer

```bash
grep -n "height - (i_tap - height + 2)|motion_max_val|VMAF_integer_feature_motion3_score" \
libvmaf/src/feature/integer_motion.c \
libvmaf/src/feature/alias.c \
libvmaf/src/feature/x86/motion_avx2.c \
libvmaf/src/feature/x86/motion_avx512.c

Expect: matches at all 4 files (verified locally).

ninja -C build && meson test -C build

Expect: 35/35 pass.

```

🤖 Generated with Claude Code

…-0158)

Verification pass confirmed that Netflix upstream PR Netflix#1486 ("Port
motion updates", MERGED 2026-04-20) is already fully absorbed into
the fork's master — not via a direct port PR but via earlier
incremental motion3 / blend / five-frame-window / moving-average
commits that landed separately.

Markers confirmed in fork master:

- `edge_8` mirror fix `i_tap = height - (i_tap - height + 2)` at
  `integer_motion.c:240`, `x86/motion_avx2.c:147`,
  `x86/motion_avx512.c:147`.
- `motion_max_val` option (default 10000.0, `FEATURE_PARAM` flag)
  at `integer_motion.c:57,118-120`.
- `VMAF_integer_feature_motion3_score` output plumbing in
  `integer_motion.c` + `alias.c`.
- All 73 coordinated Netflix golden `assertAlmostEqual` updates
  from upstream commit `62f47d5` present in the fork's python
  test files.

Fork PR #45 (`9371a0aa feat(libvmaf/feature): port upstream motion
updates`) tracked the 1:1 port but never merged — its substance
landed via fork-native work instead. End state is equivalent.

Doc-only close per user popup 2026-04-24 → "Doc-only PR":

- New ADR-0158 documents the coverage + invariants future
  /sync-upstream runs must preserve.
- Rebase-notes entry 0051 lists the four markers + fork-local
  motion extensions that must not collide on rebase.
- BACKLOG T4-1 flipped to DONE with a verification reference.

No CHANGELOG entry — no user-visible delta.
No code change — `meson test -C build` → 35/35 (unchanged).

Closes backlog item T4-1.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@lusoris lusoris merged commit 383190a into master Apr 24, 2026
62 of 63 checks passed
@lusoris lusoris deleted the docs/netflix-1486-verified-present branch April 24, 2026 14:48
@github-actions github-actions Bot mentioned this pull request Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant