Conversation
…-0158) Verification pass confirmed that Netflix upstream PR Netflix#1486 ("Port motion updates", MERGED 2026-04-20) is already fully absorbed into the fork's master — not via a direct port PR but via earlier incremental motion3 / blend / five-frame-window / moving-average commits that landed separately. Markers confirmed in fork master: - `edge_8` mirror fix `i_tap = height - (i_tap - height + 2)` at `integer_motion.c:240`, `x86/motion_avx2.c:147`, `x86/motion_avx512.c:147`. - `motion_max_val` option (default 10000.0, `FEATURE_PARAM` flag) at `integer_motion.c:57,118-120`. - `VMAF_integer_feature_motion3_score` output plumbing in `integer_motion.c` + `alias.c`. - All 73 coordinated Netflix golden `assertAlmostEqual` updates from upstream commit `62f47d5` present in the fork's python test files. Fork PR #45 (`9371a0aa feat(libvmaf/feature): port upstream motion updates`) tracked the 1:1 port but never merged — its substance landed via fork-native work instead. End state is equivalent. Doc-only close per user popup 2026-04-24 → "Doc-only PR": - New ADR-0158 documents the coverage + invariants future /sync-upstream runs must preserve. - Rebase-notes entry 0051 lists the four markers + fork-local motion extensions that must not collide on rebase. - BACKLOG T4-1 flipped to DONE with a verification reference. No CHANGELOG entry — no user-visible delta. No code change — `meson test -C build` → 35/35 (unchanged). Closes backlog item T4-1. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification pass confirmed that Netflix upstream PR #1486 "Port motion updates" (MERGED 2026-04-20) is already fully absorbed into the fork's master — not via a direct port PR but via earlier incremental motion3 / blend / five-frame-window / moving-average commits that landed separately.
Markers confirmed present in fork master:
edge_8mirror fixi_tap = height - (i_tap - height + 2)atinteger_motion.c:240,x86/motion_avx2.c:147,x86/motion_avx512.c:147.motion_max_valoption (default 10000.0,FEATURE_PARAMflag) atinteger_motion.c:57,118-120.VMAF_integer_feature_motion3_scoreoutput plumbing ininteger_motion.c+alias.c.assertAlmostEqualupdates from upstream commit62f47d5present in fork's python test files.Fork PR #45 (
9371a0aa feat(libvmaf/feature): port upstream motion updates) tracked the 1:1 port attempt but never merged — its substance landed via fork-native work instead. End state is equivalent.Scope
Doc-only close per user popup 2026-04-24 → "Doc-only PR":
docs/adr/0158-netflix-1486-motion-updates-verified-present.md— documents the coverage + invariants future/sync-upstreamruns must preserve.docs/rebase-notes.md— entry 0051 lists the four markers + fork-local motion extensions that must not collide on rebase.docs/adr/README.md— ADR-0158 index row.No CHANGELOG entry — no user-visible delta.
No code change —
meson test -C build→ 35/35 (unchanged).Test
Type
Netflix golden-data gate (ADR-0024)
Cross-backend numerical results
```text
N/A — zero code change; no numerical path touched.
```
Deep-dive deliverables (ADR-0108)
Reproducer
```bash
grep -n "height - (i_tap - height + 2)|motion_max_val|VMAF_integer_feature_motion3_score" \
libvmaf/src/feature/integer_motion.c \
libvmaf/src/feature/alias.c \
libvmaf/src/feature/x86/motion_avx2.c \
libvmaf/src/feature/x86/motion_avx512.c
Expect: matches at all 4 files (verified locally).
ninja -C build && meson test -C build
Expect: 35/35 pass.
```
🤖 Generated with Claude Code