Fix/depthai installer for mac #1053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
PetrNovota
commented
Jul 15, 2024
PetrNovota
commented
- install homebrew and git only when needed
- improve error message to see which script failed
added 5 commits
July 15, 2024 11:17
moratom
approved these changes
Jul 22, 2024
Collaborator
moratom
left a comment
moratom
left a comment
There was a problem hiding this comment.
Thanks @PetrNovota.
LGTM if tested.
Comment on lines
-130
to
-132
| echo "Upgrading brew." | ||
| brew update | ||
|
|
Collaborator
There was a problem hiding this comment.
@PetrNovota this is not needed anymore or was it never needed?
Collaborator
Author
There was a problem hiding this comment.
this was never needed. I think this is actually relatively dangerous to do without the users permission.
…equire bash version 4 and higher to avoid syntax errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.