Skip to content

Conversation

@Erol444
Copy link
Contributor

@Erol444 Erol444 commented Mar 21, 2021

Added camera video example/docs/tests, which is suitable for high res & low latency

@Erol444 Erol444 requested a review from themarpe March 21, 2021 16:20
@Erol444 Erol444 changed the base branch from main to develop March 21, 2021 16:20
@Erol444
Copy link
Contributor Author

Erol444 commented Mar 21, 2021

I will also change camera_video_example.cpp inside depthai-core to use setVideoSize isntead of setPreviewSize (Martin confirmed this)

@Luxonis-Brandon
Copy link
Contributor

Thanks!

@@ -0,0 +1,30 @@
28 - Camera video high resolution
=========================
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please match the header length (throws a warning otherwise)

.. code-block:: bash
:substitutions:

python3 -m pip install --extra-index-url https://artifacts.luxonis.com/artifactory/luxonis-python-snapshot-local/ depthai==|release|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use .. include:: /includes/install_from_pypi.rst, like here - https://github.com/luxonis/depthai-python/blob/develop/docs/source/samples/09_mono_mobilenet.rst

28 - Camera video high resolution
=========================

This example shows how to use high resolution video at low latency. Compared to `01_rbg_preview`, this demo outputs NV12 frames whereas
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add a link to the 01 issue, like

:ref:`01 - RGB Preview`

…ing), replaced setup with install_from_pypi.rst
@Erol444 Erol444 requested a review from VanDavv March 21, 2021 21:18
Copy link
Contributor

@VanDavv VanDavv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@themarpe themarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also is 2000x1000 specifically intended? Otherwise we could do 1920x1080 and 1080p sensor resolution.

LGTM apart from that

@Erol444 Erol444 merged commit c8a5a9a into develop Mar 23, 2021
@Erol444 Erol444 deleted the camera_video_example branch March 23, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants