Skip to content

Fix dependencies for arm64 #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 13, 2021
Merged

Fix dependencies for arm64 #322

merged 5 commits into from
Oct 13, 2021

Conversation

@SzabolcsGergely
Copy link
Contributor

@SzabolcsGergely SzabolcsGergely commented Jul 22, 2021 •
edited
Loading

Skip opencv-python install on jetson, since it would crash with illegal instruction

@SzabolcsGergely SzabolcsGergely force-pushed the arm64_dependency_fix branch 2 times, most recently from 1acca28 to 849b5ce Compare July 23, 2021 00:20
@themarpe
Copy link
Collaborator

themarpe commented Jul 23, 2021

Does it otherwise reinstall the existing opencv on Jetson?

@SzabolcsGergely
Copy link
Contributor Author

SzabolcsGergely commented Jul 23, 2021

Does it otherwise reinstall the existing opencv on Jetson?

It doesn't remove the vanilla opencv, but it takes precedence.
In order to remove the new install one needs to do: python3 -m pip uninstall opencv-python AND python3 -m pip remove opencv-python IIRC. otherwase fails with illegal instruction.
Unless OPENBLAS_CORE_TYPE env variable is set to armv8. (Didn't test this one on the very latest jetson though)

@themarpe
Copy link
Collaborator

themarpe commented Jul 23, 2021

Can we check if already installed and if not still install it but leave a huge warning related to OPENBLAS_CORE_TYPE env var?
Just to still install everything needed on systems where opencv-python isn't preinstalled

@SzabolcsGergely
Copy link
Contributor Author

SzabolcsGergely commented Jul 27, 2021

Can we check if already installed and if not still install it but leave a huge warning related to OPENBLAS_CORE_TYPE env var?
Just to still install everything needed on systems where opencv-python isn't preinstalled

Will reinstall latest jetson these days on nano and test it out, then update this PR

@SzabolcsGergely
Copy link
Contributor Author

SzabolcsGergely commented Oct 13, 2021

Ran on clean install "as it is" and also with manually installed opencv-python, but without OPENBLAS_CORE_TYPE set.

themarpe
themarpe requested changes Oct 13, 2021
View reviewed changes
@SzabolcsGergely SzabolcsGergely merged commit 13f3d68 into main Oct 13, 2021
@SzabolcsGergely SzabolcsGergely deleted the arm64_dependency_fix branch October 13, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@themarpe themarpe themarpe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SzabolcsGergely @themarpe