Skip to content

Updated stereoDepth docs #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 20, 2021
Merged

Updated stereoDepth docs #342

merged 3 commits into from
Aug 20, 2021

Conversation

@Erol444
Copy link
Contributor

@Erol444 Erol444 commented Aug 11, 2021

No description provided.

@Erol444 Erol444 requested a review from saching13 August 11, 2021 13:38
saching13
saching13 suggested changes Aug 11, 2021
View reviewed changes
@saching13
Copy link
Contributor

saching13 commented Aug 11, 2021

And I think we should also add details on the Unexposed API settings available so that the user can know what they do.

@saching13
Copy link
Contributor

saching13 commented Aug 11, 2021

@Luxonis-Brandon should we add a description on each block?

@Luxonis-Brandon
Copy link
Contributor

Luxonis-Brandon commented Aug 11, 2021

And I think we should also add details on the Unexposed API settings available so that the user can know what they do.

Yes. Totally agree.

@Luxonis-Brandon should we add a description on each block?

Yes, I think so @saching13 but only quickly browsed. Your call.

@Erol444 Erol444 requested a review from saching13 August 18, 2021 10:00
@Luxonis-Brandon
Copy link
Contributor

Luxonis-Brandon commented Aug 20, 2021

Oh @saching13 should we merge this or should we add the description to each block?

@saching13
Copy link
Contributor

saching13 commented Aug 20, 2021

Oh @saching13 should we merge this or should we add the description to each block?

We decided we will merge this and create a new PR for a description of each block.
I will review this once tonight and will merge it.

@Luxonis-Brandon
Copy link
Contributor

Luxonis-Brandon commented Aug 20, 2021

Great thanks @saching13 !

@saching13 saching13 closed this Aug 20, 2021
@saching13 saching13 reopened this Aug 20, 2021
@saching13 saching13 merged commit 6091cdb into main Aug 20, 2021
@saching13 saching13 deleted the update_depth_docs branch August 20, 2021 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@saching13 saching13 saching13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Erol444 @saching13 @Luxonis-Brandon