Skip to content

Fixed ddr typo #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 12, 2021
Merged

Fixed ddr typo #344

merged 6 commits into from
Aug 12, 2021

Conversation

@Erol444
Copy link
Contributor

@Erol444 Erol444 commented Aug 11, 2021 •
edited
Loading

@Erol444 Erol444 requested a review from VanDavv August 11, 2021 20:31
@alex-luxonis
Copy link
Collaborator

alex-luxonis commented Aug 11, 2021

If we're at it, it would be good to update these too:

print(f"Chip temperature - average: {t.average:.2f}, css: {t.css:.2f}, mss: {t.mss:.2f}, upa0: {t.upa:.2f}, upa1: {t.dss:.2f}")
print(f"Cpu usage - Leon OS: {info.leonCssCpuUsage.average * 100:.2f}%, Leon RT: {info.leonMssCpuUsage.average * 100:.2f} %")

upa0 -> upa (this is the SHAVE block - μP array)
upa1 -> dss (DDR subsystem)
Leon OS -> Leon CSS
Leon RT -> Leon MSS

@Erol444
Copy link
Contributor Author

Erol444 commented Aug 11, 2021

If we're at it, it would be good to update these too:

print(f"Chip temperature - average: {t.average:.2f}, css: {t.css:.2f}, mss: {t.mss:.2f}, upa0: {t.upa:.2f}, upa1: {t.dss:.2f}")
print(f"Cpu usage - Leon OS: {info.leonCssCpuUsage.average * 100:.2f}%, Leon RT: {info.leonMssCpuUsage.average * 100:.2f} %")

upa0 -> upa (this is the SHAVE block - μP array)
upa1 -> dss (DDR subsystem)
Leon OS -> Leon CSS
Leon RT -> Leon MSS

Thanks, Alex, I will rename these and add info about it in docs!

@Erol444 Erol444 mentioned this pull request Aug 12, 2021
Merged
@Erol444 Erol444 requested a review from alex-luxonis August 12, 2021 00:54
alex-luxonis
alex-luxonis reviewed Aug 12, 2021
View reviewed changes
docs/source/samples/system_information.rst Outdated
----------------------------------------
- :code:`upa` represents the temperature of the SHAVE block
- :code:`dss` represents the temperature od the DRR subsystem
Copy link
Collaborator

@alex-luxonis alex-luxonis Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: DRR -> DDR

Copy link
Contributor Author

@Erol444 Erol444 Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why I'm so keen on typing this incorrectly... Thanks for catching it again:)

@Erol444 Erol444 merged commit c22ef3c into main Aug 12, 2021
@Erol444 Erol444 deleted the sysinfo_docs_fix branch August 12, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex-luxonis alex-luxonis alex-luxonis approved these changes

@VanDavv VanDavv Awaiting requested review from VanDavv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Erol444 @alex-luxonis