Skip to content

Conversation

@Erol444
Copy link
Contributor

@Erol444 Erol444 commented Nov 21, 2021

what else is missing in the docs @szabi-luxonis ?

@SzabolcsGergely
Copy link
Contributor

SzabolcsGergely commented Nov 21, 2021

Subpixel mode description should be changed, 3 is the default now instead 5.
https://github.com/luxonis/depthai-python/pull/428/files#diff-acfee2c382896d3423be1a43a5edd9e862b4083769fe1a59e8cfd4bc60bacdeaR122

instead this:

        then software interpolation is done on Shave, resulting a final disparity with 5 fractional bits, resulting in significantly more granular depth
        steps (32 additional steps between the integer-pixel depth steps), and also theoretically, longer-distance depth viewing - as the maximum depth
        is no longer limited by a feature being a full integer pixel-step apart, but rather 1/32 of a pixel. In this mode, stereo cameras perform: :code:`96 depth steps * 32 subpixel depth steps = 3,072 depth steps.`
        Note that Subpixel and Extended Disparity are not yet supported simultaneously (which would result in :code:`191 * 32 = 6,112 depth steps`), but should be available in the near future (`Pull Request <https://github.com/luxonis/depthai-python/pull/347>`__).

change to:

        then software interpolation is done on Shave, resulting a final disparity with 3 fractional bits, resulting in significantly more granular depth
        steps (8 additional steps between the integer-pixel depth steps), and also theoretically, longer-distance depth viewing - as the maximum depth
        is no longer limited by a feature being a full integer pixel-step apart, but rather 1/8 of a pixel. In this mode, stereo cameras perform: :code:`95 depth steps * 8 subpixel depth steps + 1 = 761 depth steps.`
        Note that Subpixel and Extended Disparity are not yet supported simultaneously.).

@Erol444 Erol444 marked this pull request as ready for review November 21, 2021 19:18
Erol444 and others added 2 commits November 22, 2021 00:11
Co-authored-by: szabi-luxonis <60790666+szabi-luxonis@users.noreply.github.com>
@SzabolcsGergely SzabolcsGergely merged commit 3cbc455 into main Nov 22, 2021
@SzabolcsGergely SzabolcsGergely deleted the stereo_node_fix branch November 22, 2021 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants