Add qt5 to install script dependencies #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themarpe
approved these changes
Nov 30, 2021
Collaborator
themarpe
left a comment
themarpe
left a comment
There was a problem hiding this comment.
Is this okay to install for non RPi hosts as well?
LGTM otherwise
Contributor
Author
|
I installed it on my Ubuntu 20.04 and it worked fine too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds QT5 dependencies to install script, also removes the libraries that were causing issues (reported here CC @saching13 ).
Will be testing more on other Raspbian distributions to discover potential issues like the mentioned above