Enhance stereo depth develop merge #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saching13
reviewed
Sep 10, 2020
Contributor
saching13
left a comment
saching13
left a comment
There was a problem hiding this comment.
Looks good to me. @alex-luxonis was working on fixing a bug in enhance_stereo_depth. Wouldn't it be better to merge after fixing that ?
Contributor
Author
It has other good features that we want to have in develop. Might take a lot of time to fix LR check, so for now we disable it. |
themarpe
reviewed
Sep 10, 2020
…s along with place holders for rgb camera calibrations.
… EEPROM write in depthai-core
Contributor
|
Everything looks great to me. Tested on depthai |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance stereo depth develop merge