Fix swapped width and height parameters in reshape function #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themarpe
approved these changes
Jan 11, 2022
Collaborator
themarpe
left a comment
themarpe
left a comment
There was a problem hiding this comment.
Thanks for catching this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the width is equal to the height, so things worked anyway, but the preview image will be garbled when the size is changed to anything non-square here:
depthai-python/examples/ColorCamera/rgb_camera_control.py
Line 54 in eba227a
As best practice, it might be a good idea to not use square shapes so this error would have been more obvious.