Skip to content

Fix get dict methods #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2020
Merged

Fix get dict methods #54

merged 1 commit into from
Oct 12, 2020

Conversation

@SzabolcsGergely
Copy link
Contributor

@SzabolcsGergely SzabolcsGergely commented Oct 12, 2020

get_dict was acting as an attribute, and was accessed as object.get_dict instead object.get_dict()

@SzabolcsGergely SzabolcsGergely changed the base branch from main to develop October 12, 2020 15:56
@themarpe
Copy link
Collaborator

themarpe commented Oct 12, 2020

LGTM

@SzabolcsGergely SzabolcsGergely merged commit c377d8d into develop Oct 12, 2020
@SzabolcsGergely SzabolcsGergely deleted the fix_get_dict_methods branch October 12, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@themarpe themarpe Awaiting requested review from themarpe

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SzabolcsGergely @themarpe