Skip to content

Fixed and improved script for installing dependencies #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2022
Merged

Fixed and improved script for installing dependencies #670

merged 1 commit into from
Aug 31, 2022

Conversation

@themarpe
Copy link
Collaborator

@themarpe themarpe commented Aug 31, 2022 •
edited
Loading

Because of set -e the check for uvcdynctrl package prematurely exited the script without any feedback.

Added feedback as well as fixed the uvcdynctrl package detection

Main issue was that udev rules weren't installed afterwards

@themarpe themarpe requested a review from Erol444 August 31, 2022 22:37
@themarpe themarpe merged commit b2566d8 into main Aug 31, 2022
@themarpe themarpe deleted the install_dependencies_fix branch August 31, 2022 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Erol444 Erol444 Erol444 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@themarpe @Erol444