Change Java install link to Adoptium #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
In the book I'm linking to OpenJDK, which is not Oracle JDK. Open JDK does not require to have an Oracle account, so I don't see the point of removeing the link. I could add the adoptium link, but removing OpenJDK linking it to Oracle is missleading. Am I missing something? |
Contributor
Author
|
I've completely misread that, no idea how; sorry. I'd still argue that Adoptium would be better to link as it's a little more user-friendly and has an installer compared to just downloading a zip or tarball of everything. I can change the link back if you'd like as this still has some grammar fixes and fixes the hyperlink not working. |
Owner
|
Maybe it's better to include both and keep the grammar and the rest of the fixes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When downloading SDKs from Oracle, you need to have an Oracle account. Many people don't like that, so this changes the link to Adoptium's prebuilt SDKs.