HTML Unicode parsing #51
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't use \u escape because it doesn't work on Python 2 without a u prefix. Instead use literal UTF-8 bytes.
These fail on a system where libxml doesn't support iconv (try commenting out _UNICODE_ENCODING = enc in parser.pxi). The second test always fails because it is converted to UTF-8 and back as Latin-1.
…s UTF-8, it overrides the encoding in the parser to interpret the string as UTF-8.
…ings. If the encoding is unspecified, explicitly sets it to UTF-8 to match the way it will actually be encoded.
|
I have debugged this issue for the last few hours and came up with a patch that is essentially the same. Mine isn't as complete as this one is, so I'm not going to post it here. Long story short, I second this patch. It even looks like it's pretty easy to merge. This issue came up for me with Python 3. |
|
Thanks, 293302c fixed this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attached is a fix for LP #1002581:
https://bugs.launchpad.net/lxml/+bug/1002581
Note: This patch is funded by my employer, Google. If I am credited, please use my work email address mgiuca@google.com.