-
Notifications
You must be signed in to change notification settings - Fork 8
inetdiag.Parse and message cache #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 108
💛 - Coveralls |
|
Review status: 0 of 7 files reviewed at latest revision, all discussions resolved. cache/cache.go, line 22 at r2 (raw file):
"stale" might be better than "past". It doesn't contain the inodes from the last round of updates, it contains the inodes from the last round that did not get updated this round. cache/cache.go, line 31 at r2 (raw file):
...and returns the evicted value from the cache. inetdiag/inetdiag_test.go, line 155 at r2 (raw file):
I can't tell the difference between the good input data and the bad input data. Is that okay? Maybe. But I thought I should let you know. Comments from Reviewable |
|
Review status: 0 of 7 files reviewed at latest revision, 3 unresolved discussions, all commit checks successful. cache/cache.go, line 22 at r2 (raw file): Previously, pboothe (Peter Boothe) wrote…
It initially contains all existing connections, as of last cycle. Connections are removed as they are replaced in the new cycle. cache/cache.go, line 31 at r2 (raw file): Previously, pboothe (Peter Boothe) wrote…
Done. inetdiag/inetdiag_test.go, line 155 at r2 (raw file): Previously, pboothe (Peter Boothe) wrote…
Improved comments. Comments from Reviewable |
Adds basic inet message and attribute parsing, and a message cache.
This change is