Skip to content

Conversation

@gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented May 10, 2018

Support for transcribing netlink messages into protobufs.

  • moves tcp enumerations from inetdiag.go
  • adds INET_DIAG_... needed by new tools
  • improves tests
  • fixes bug in ipv4 handling of inet diag msg.

Some attribute types are not yet supported, and will be added as needed.


This change is Reviewable

@coveralls
Copy link

coveralls commented May 10, 2018

Pull Request Test Coverage Report for Build 82

  • 143 of 152 (94.08%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+14.7%) to 89.958%

Changes Missing Coverage Covered Lines Changed/Added Lines %
inetdiag/inetdiag.go 1 2 50.0%
nl-proto/tools/convert.go 142 150 94.67%
Totals Coverage Status
Change from base Build 59: 14.7%
Covered Lines: 215
Relevant Lines: 239

💛 - Coveralls

@gfr10598 gfr10598 force-pushed the fill-proto branch 2 times, most recently from d7979d1 to 75ecb04 Compare May 10, 2018 20:20
@pboothe
Copy link

pboothe commented May 10, 2018

:lgtm:


Review status: 0 of 6 files reviewed at latest revision, all discussions resolved.


nl-proto/tools/convert.go, line 15 at r3 (raw file):

	// Hack to force loading library, which is currently used only in nested test.
	_ "github.com/vishvananda/netlink/nl"

I don't understand this? Why does an include in the _test file not suffice?


Comments from Reviewable

@gfr10598
Copy link
Contributor Author

Review status: 0 of 6 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


nl-proto/tools/convert.go, line 15 at r3 (raw file):

Previously, pboothe (Peter Boothe) wrote…

I don't understand this? Why does an include in the _test file not suffice?

I have no idea. But this workaround is working, so I'm running with it.


Comments from Reviewable

@gfr10598 gfr10598 merged commit 908d512 into master May 10, 2018
@gfr10598 gfr10598 deleted the fill-proto branch May 10, 2018 23:37
gfr10598 added a commit that referenced this pull request May 11, 2018
gfr10598 added a commit that referenced this pull request May 11, 2018
@gfr10598 gfr10598 added Task A small chunk of work related to a Story Sprint 9 labels May 11, 2018
@gfr10598
Copy link
Contributor Author

Issue #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sprint 9 Task A small chunk of work related to a Story

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants