Skip to content

Fix listening for a Start-Of-Frame byte #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m3y54m merged 1 commit into from
Nov 12, 2025
Merged

Fix listening for a Start-Of-Frame byte #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions first-steps/3-simple-uart-protocol/mcu/sup.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,19 +119,15 @@ void sup_handle_rx_byte(const uint8_t byte)
return;
}

// Always listen for a Start-Of-Frame byte, which can reset a broken frame transmission.
if (byte == SUP_SOF)
{
reset_rx_frame_state();
rx_frame_state->parsing_state = SUP_STATE_WAIT_ID;
return;
}

switch (rx_frame_state->parsing_state)
{
case SUP_STATE_WAIT_SOF:
// This state is effectively handled by the check above,
// but we keep the case for clarity. Any byte other than SOF is ignored.
// Listen for a Start-Of-Frame byte. Any byte other than SOF is ignored.
if (byte == SUP_SOF)
{
reset_rx_frame_state();
rx_frame_state->parsing_state = SUP_STATE_WAIT_ID;
}
break;

case SUP_STATE_WAIT_ID:
Expand Down