Skip to content

fix: config migration logic causes kits to deinit on re-upgrade#196

Merged
willpassidomo merged 1 commit intodevelopmentfrom
fix/SQDSDKS-4265-config-migration-reload-empty
Jul 1, 2022
Merged

fix: config migration logic causes kits to deinit on re-upgrade#196
willpassidomo merged 1 commit intodevelopmentfrom
fix/SQDSDKS-4265-config-migration-reload-empty

Conversation

@willpassidomo
Copy link
Contributor

Summary

  • Customer reported an odd issue where the kits are briefly initializing, de-initializing then re-initializing again on startup. I have been unable to reproduce, but based on the provided logs, it appears to be related to our migration logic released in v5.36.0. This fix adds a flag that ensures our migration logic attempted exactly 1-time per device

Testing Plan

  • none at this time

Master Issue

@willpassidomo willpassidomo requested a review from mchuangatmp July 1, 2022 17:51
@willpassidomo willpassidomo force-pushed the fix/SQDSDKS-4265-config-migration-reload-empty branch 2 times, most recently from 00f3857 to d3cfdc5 Compare July 1, 2022 19:18
@willpassidomo willpassidomo force-pushed the fix/SQDSDKS-4265-config-migration-reload-empty branch from d3cfdc5 to 0449e41 Compare July 1, 2022 19:54
@willpassidomo willpassidomo merged commit ae210c4 into development Jul 1, 2022
@willpassidomo willpassidomo deleted the fix/SQDSDKS-4265-config-migration-reload-empty branch July 1, 2022 20:15
github-actions bot pushed a commit that referenced this pull request Jul 1, 2022
## [5.41.3](v5.41.2...v5.41.3) (2022-07-01)

### Bug Fixes

* config migration logic causes kits to deinit on re-upgrade ([#196](#196)) ([ae210c4](ae210c4))
* modify() call throws an exception when user is not present ([#195](#195)) ([72731d5](72731d5))

### Updates & Maintenance

* Update Submodules ([99fed27](99fed27))
@mparticle-automation
Copy link
Collaborator

🎉 This PR is included in version 5.41.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants