fix: Add additional checks for AndroidId#87
Merged
willpassidomo merged 1 commit intodevelopmentfrom Jan 5, 2022
Merged
Conversation
willpassidomo
force-pushed
the
fix/77585-missing-androidid-check
branch
from
beffebb to
6ffa843
Compare
willpassidomo
force-pushed
the
fix/77585-missing-androidid-check
branch
2 times, most recently
from
a78ce91 to
19333de
Compare
mchuangatmp
approved these changes
Jan 4, 2022
willpassidomo
force-pushed
the
fix/77585-missing-androidid-check
branch
from
19333de to
261e50a
Compare
willpassidomo
force-pushed
the
fix/77585-missing-androidid-check
branch
from
261e50a to
02161a6
Compare
Collaborator
|
🎉 This PR is included in version 5.34.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
to mchuangatmp/mparticle-android-sdk
that referenced
this pull request
Mar 23, 2022
# [5.18.0](v5.17.0...v5.18.0) (2022-03-23) ### Bug Fixes * Add additional checks for AndroidId ([mParticle#87](https://github.com/mchuangatmp/mparticle-android-sdk/issues/87)) ([1eceea3](1eceea3)) * add dry run to fix daily cron health check job ([mParticle#95](https://github.com/mchuangatmp/mparticle-android-sdk/issues/95)) ([92c443f](92c443f)) * bad formatting in release.config.js ([mParticle#75](https://github.com/mchuangatmp/mparticle-android-sdk/issues/75)) ([253c9a3](253c9a3)) * bugfix some lint issues ([3177500](3177500)) * Change configMaxAge type from Long to int ([mParticle#91](https://github.com/mchuangatmp/mparticle-android-sdk/issues/91)) ([14ad4b5](14ad4b5)) * downgrade error log to debug ([mParticle#102](https://github.com/mchuangatmp/mparticle-android-sdk/issues/102)) ([293ce35](293ce35)) * Fix cross platforms for Android forked PRs when checking out code ([mParticle#97](https://github.com/mchuangatmp/mparticle-android-sdk/issues/97)) ([90b2760](90b2760)) * Hardcode macos version for Github Actions ([de1f552](de1f552)) * keep package names in proguard to prevent collisions ([mParticle#109](https://github.com/mchuangatmp/mparticle-android-sdk/issues/109)) ([a8df4fe](a8df4fe)) * post new release versions to github ([707c9ec](707c9ec)) * remove Appsee submodule ([8a172b4](8a172b4)) * remove bintray url from kits ([323d57d](323d57d)) * Remove broken Sonatype plugin dependency ([41e86a1](41e86a1)) * remove deprecated kahuna kit for semantic release ([9defb08](9defb08)) * test commit ([e1fb76e](e1fb76e)) * Transitive dependency, remove version range for localbroadcastmanager ([5f94984](5f94984)) * Treat duplicate Push tokens as background tokens if no current Session ([63eb698](63eb698)) * typo in GA4 kit name ([mParticle#112](https://github.com/mchuangatmp/mparticle-android-sdk/issues/112)) ([45f9770](45f9770)) * typo in release.config.js ([mParticle#76](https://github.com/mchuangatmp/mparticle-android-sdk/issues/76)) ([cf30ab8](cf30ab8)) * update java docs syntax after gradle upgrade ([mParticle#98](https://github.com/mchuangatmp/mparticle-android-sdk/issues/98)) ([9a8e22e](9a8e22e)) * update with proper kit configuration ([mParticle#113](https://github.com/mchuangatmp/mparticle-android-sdk/issues/113)) ([7496077](7496077)) ### Features * Add configMaxAge to MParticleOptions ([mParticle#85](https://github.com/mchuangatmp/mparticle-android-sdk/issues/85)) ([eaadccd](eaadccd)) * add in ktlintcheck ([mParticle#108](https://github.com/mchuangatmp/mparticle-android-sdk/issues/108)) ([f75c5b6](f75c5b6)) * add in lint error check for kits ([81307ae](81307ae)) * add in semantic release work ([8e26f79](8e26f79)) * add in sonatype work ([6e73455](6e73455)) * add support for firebase messaging v22.0.0 ([0facc42](0facc42)) * add upload bypass support to logscreen ([177a5d5](177a5d5)) * Android id disabled default true ([mParticle#89](https://github.com/mchuangatmp/mparticle-android-sdk/issues/89)) ([7fc0217](7fc0217)) * Implement event upload bypass option ([3d8a967](3d8a967)) * remove deprecated methods, AppConfig ([mParticle#100](https://github.com/mchuangatmp/mparticle-android-sdk/issues/100)) ([a5a934a](a5a934a)) * split configuration into core and kits ([mParticle#103](https://github.com/mchuangatmp/mparticle-android-sdk/issues/103)) ([766e0d3](766e0d3)) * switch crossplatform tests to run on target repo due to token permission scope ([b7e946a](b7e946a)) * test gpg key ([3239c02](3239c02)) * turn on lint errors ([9c98535](9c98535)) * Update Submodules ([b634d90](b634d90)) * Update Submodules ([eb4573f](eb4573f)) * Update Submodules ([45bfd95](45bfd95)) * Update Submodules ([9aa5077](9aa5077)) * Update Submodules ([d584a3b](d584a3b)) * Update Submodules ([055c896](055c896)) * Update Submodules ([6b2d6be](6b2d6be)) * Update Submodules ([ed75216](ed75216)) * Update Submodules ([216c775](216c775)) * Update Submodules ([1826382](1826382)) * Update Submodules ([1cf5869](1cf5869)) * Update Submodules ([e46a282](e46a282)) * Update Submodules ([4a34f66](4a34f66)) * Update Submodules ([4918847](4918847)) * upgrade to AGP 7.X ([267bf36](267bf36)) ### Reverts * Rollback Kotlin upgrade ([7deee2e](7deee2e))
github-actions bot
pushed a commit
to mchuangatmp/mparticle-android-sdk
that referenced
this pull request
Mar 23, 2022
# [5.18.0](v5.17.0...v5.18.0) (2022-03-23) ### Bug Fixes * Add additional checks for AndroidId ([mParticle#87](https://github.com/mchuangatmp/mparticle-android-sdk/issues/87)) ([1eceea3](1eceea3)) * add dry run to fix daily cron health check job ([mParticle#95](https://github.com/mchuangatmp/mparticle-android-sdk/issues/95)) ([92c443f](92c443f)) * bad formatting in release.config.js ([mParticle#75](https://github.com/mchuangatmp/mparticle-android-sdk/issues/75)) ([253c9a3](253c9a3)) * bugfix some lint issues ([3177500](3177500)) * Change configMaxAge type from Long to int ([mParticle#91](https://github.com/mchuangatmp/mparticle-android-sdk/issues/91)) ([14ad4b5](14ad4b5)) * downgrade error log to debug ([mParticle#102](https://github.com/mchuangatmp/mparticle-android-sdk/issues/102)) ([293ce35](293ce35)) * Fix cross platforms for Android forked PRs when checking out code ([mParticle#97](https://github.com/mchuangatmp/mparticle-android-sdk/issues/97)) ([90b2760](90b2760)) * Hardcode macos version for Github Actions ([de1f552](de1f552)) * keep package names in proguard to prevent collisions ([mParticle#109](https://github.com/mchuangatmp/mparticle-android-sdk/issues/109)) ([a8df4fe](a8df4fe)) * post new release versions to github ([707c9ec](707c9ec)) * remove Appsee submodule ([8a172b4](8a172b4)) * remove bintray url from kits ([323d57d](323d57d)) * Remove broken Sonatype plugin dependency ([41e86a1](41e86a1)) * remove deprecated kahuna kit for semantic release ([9defb08](9defb08)) * test commit ([1283aba](1283aba)) * Transitive dependency, remove version range for localbroadcastmanager ([5f94984](5f94984)) * Treat duplicate Push tokens as background tokens if no current Session ([63eb698](63eb698)) * typo in GA4 kit name ([mParticle#112](https://github.com/mchuangatmp/mparticle-android-sdk/issues/112)) ([45f9770](45f9770)) * typo in release.config.js ([mParticle#76](https://github.com/mchuangatmp/mparticle-android-sdk/issues/76)) ([cf30ab8](cf30ab8)) * update java docs syntax after gradle upgrade ([mParticle#98](https://github.com/mchuangatmp/mparticle-android-sdk/issues/98)) ([9a8e22e](9a8e22e)) * update with proper kit configuration ([mParticle#113](https://github.com/mchuangatmp/mparticle-android-sdk/issues/113)) ([7496077](7496077)) ### Features * Add configMaxAge to MParticleOptions ([mParticle#85](https://github.com/mchuangatmp/mparticle-android-sdk/issues/85)) ([eaadccd](eaadccd)) * add in ktlintcheck ([mParticle#108](https://github.com/mchuangatmp/mparticle-android-sdk/issues/108)) ([f75c5b6](f75c5b6)) * add in lint error check for kits ([81307ae](81307ae)) * add in semantic release work ([8e26f79](8e26f79)) * add in sonatype work ([6e73455](6e73455)) * add support for firebase messaging v22.0.0 ([0facc42](0facc42)) * add upload bypass support to logscreen ([177a5d5](177a5d5)) * Android id disabled default true ([mParticle#89](https://github.com/mchuangatmp/mparticle-android-sdk/issues/89)) ([7fc0217](7fc0217)) * Implement event upload bypass option ([3d8a967](3d8a967)) * remove deprecated methods, AppConfig ([mParticle#100](https://github.com/mchuangatmp/mparticle-android-sdk/issues/100)) ([a5a934a](a5a934a)) * split configuration into core and kits ([mParticle#103](https://github.com/mchuangatmp/mparticle-android-sdk/issues/103)) ([766e0d3](766e0d3)) * switch crossplatform tests to run on target repo due to token permission scope ([b7e946a](b7e946a)) * test gpg key ([dad7acd](dad7acd)) * turn on lint errors ([9c98535](9c98535)) * Update Submodules ([b634d90](b634d90)) * Update Submodules ([eb4573f](eb4573f)) * Update Submodules ([45bfd95](45bfd95)) * Update Submodules ([9aa5077](9aa5077)) * Update Submodules ([d584a3b](d584a3b)) * Update Submodules ([055c896](055c896)) * Update Submodules ([6b2d6be](6b2d6be)) * Update Submodules ([ed75216](ed75216)) * Update Submodules ([216c775](216c775)) * Update Submodules ([1826382](1826382)) * Update Submodules ([1cf5869](1cf5869)) * Update Submodules ([e46a282](e46a282)) * Update Submodules ([4a34f66](4a34f66)) * Update Submodules ([4918847](4918847)) * upgrade to AGP 7.X ([267bf36](267bf36)) ### Reverts * Rollback Kotlin upgrade ([7deee2e](7deee2e))
github-actions bot
pushed a commit
to mchuangatmp/mparticle-android-sdk
that referenced
this pull request
Mar 23, 2022
# [5.18.0](v5.17.0...v5.18.0) (2022-03-23) ### Bug Fixes * Add additional checks for AndroidId ([mParticle#87](https://github.com/mchuangatmp/mparticle-android-sdk/issues/87)) ([1eceea3](1eceea3)) * add dry run to fix daily cron health check job ([mParticle#95](https://github.com/mchuangatmp/mparticle-android-sdk/issues/95)) ([92c443f](92c443f)) * bad formatting in release.config.js ([mParticle#75](https://github.com/mchuangatmp/mparticle-android-sdk/issues/75)) ([253c9a3](253c9a3)) * bugfix some lint issues ([3177500](3177500)) * Change configMaxAge type from Long to int ([mParticle#91](https://github.com/mchuangatmp/mparticle-android-sdk/issues/91)) ([14ad4b5](14ad4b5)) * downgrade error log to debug ([mParticle#102](https://github.com/mchuangatmp/mparticle-android-sdk/issues/102)) ([293ce35](293ce35)) * Fix cross platforms for Android forked PRs when checking out code ([mParticle#97](https://github.com/mchuangatmp/mparticle-android-sdk/issues/97)) ([90b2760](90b2760)) * Hardcode macos version for Github Actions ([de1f552](de1f552)) * keep package names in proguard to prevent collisions ([mParticle#109](https://github.com/mchuangatmp/mparticle-android-sdk/issues/109)) ([a8df4fe](a8df4fe)) * post new release versions to github ([707c9ec](707c9ec)) * remove Appsee submodule ([8a172b4](8a172b4)) * remove bintray url from kits ([323d57d](323d57d)) * Remove broken Sonatype plugin dependency ([41e86a1](41e86a1)) * remove deprecated kahuna kit for semantic release ([9defb08](9defb08)) * test commit ([5fdbf9e](5fdbf9e)) * Transitive dependency, remove version range for localbroadcastmanager ([5f94984](5f94984)) * Treat duplicate Push tokens as background tokens if no current Session ([63eb698](63eb698)) * typo in GA4 kit name ([mParticle#112](https://github.com/mchuangatmp/mparticle-android-sdk/issues/112)) ([45f9770](45f9770)) * typo in release.config.js ([mParticle#76](https://github.com/mchuangatmp/mparticle-android-sdk/issues/76)) ([cf30ab8](cf30ab8)) * update java docs syntax after gradle upgrade ([mParticle#98](https://github.com/mchuangatmp/mparticle-android-sdk/issues/98)) ([9a8e22e](9a8e22e)) * update with proper kit configuration ([mParticle#113](https://github.com/mchuangatmp/mparticle-android-sdk/issues/113)) ([7496077](7496077)) ### Features * Add configMaxAge to MParticleOptions ([mParticle#85](https://github.com/mchuangatmp/mparticle-android-sdk/issues/85)) ([eaadccd](eaadccd)) * add in ktlintcheck ([mParticle#108](https://github.com/mchuangatmp/mparticle-android-sdk/issues/108)) ([f75c5b6](f75c5b6)) * add in lint error check for kits ([81307ae](81307ae)) * add in semantic release work ([8e26f79](8e26f79)) * add in sonatype work ([6e73455](6e73455)) * add support for firebase messaging v22.0.0 ([0facc42](0facc42)) * add upload bypass support to logscreen ([177a5d5](177a5d5)) * Android id disabled default true ([mParticle#89](https://github.com/mchuangatmp/mparticle-android-sdk/issues/89)) ([7fc0217](7fc0217)) * Implement event upload bypass option ([3d8a967](3d8a967)) * remove deprecated methods, AppConfig ([mParticle#100](https://github.com/mchuangatmp/mparticle-android-sdk/issues/100)) ([a5a934a](a5a934a)) * split configuration into core and kits ([mParticle#103](https://github.com/mchuangatmp/mparticle-android-sdk/issues/103)) ([766e0d3](766e0d3)) * switch crossplatform tests to run on target repo due to token permission scope ([b7e946a](b7e946a)) * test gpg key ([6f782b6](6f782b6)) * turn on lint errors ([9c98535](9c98535)) * Update Submodules ([b634d90](b634d90)) * Update Submodules ([eb4573f](eb4573f)) * Update Submodules ([45bfd95](45bfd95)) * Update Submodules ([9aa5077](9aa5077)) * Update Submodules ([d584a3b](d584a3b)) * Update Submodules ([055c896](055c896)) * Update Submodules ([6b2d6be](6b2d6be)) * Update Submodules ([ed75216](ed75216)) * Update Submodules ([216c775](216c775)) * Update Submodules ([1826382](1826382)) * Update Submodules ([1cf5869](1cf5869)) * Update Submodules ([e46a282](e46a282)) * Update Submodules ([4a34f66](4a34f66)) * Update Submodules ([4918847](4918847)) * upgrade to AGP 7.X ([267bf36](267bf36)) ### Reverts * Rollback Kotlin upgrade ([7deee2e](7deee2e))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a missing check for whether we should collect and include the AndroidId in Identity requests
Testing Plan
updated existing checks to ensure that AndroidId is not collected when
isAndroidIdDisabled() == trueMaster Issue
Closes https://mparticle.tpondemand.com/restui/board.aspx?#page=bug/77526&boardPopup=userstory/77585