fix: Design Revisions #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
requested review from
BrandonStalnaker,
einsteinx2 and
rmi22186
rmi22186
requested changes
Mar 17, 2022
Member
rmi22186
left a comment
rmi22186
left a comment
There was a problem hiding this comment.
A few minor comments, otherwise LGTM.
core-sdk-samples/higgs-shop-sample-app/src/components/NavigationMenu/NavigationMenuItem.tsx
Outdated
Show resolved
Hide resolved
...-sdk-samples/higgs-shop-sample-app/src/features/OrderDetails/OrderDetailsCustomerDetails.tsx
Show resolved
Hide resolved
rmi22186
approved these changes
Mar 17, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
# 1.0.0 (2022-03-29) ### Bug Fixes * Design Revisions ([#5](#5)) ([ec938af](ec938af)) ### Features * add Dialog to warn if API Key is missing ([#4](#4)) ([c911184](c911184)) * add Identity workflow and Account Details page ([#2](#2)) ([7f86704](7f86704)) * add Lato font to UI ([#3](#3)) ([7b4e0f7](7b4e0f7))
Contributor
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
# [1.1.0](v1.0.0...v1.1.0) (2022-03-29) ### Bug Fixes * Design Revisions ([#5](#5)) ([ec938af](ec938af)) ### Features * add Dialog to warn if API Key is missing ([#4](#4)) ([c911184](c911184)) * add Identity workflow and Account Details page ([#2](#2)) ([7f86704](7f86704)) * add Lato font to UI ([#3](#3)) ([7b4e0f7](7b4e0f7))
Contributor
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
alexs-mparticle
pushed a commit
that referenced
this pull request
Mar 30, 2022
# 1.0.0 (2022-03-29) ### Bug Fixes * Design Revisions ([#5](#5)) ([ec938af](ec938af)) ### Features * add Dialog to warn if API Key is missing ([#4](#4)) ([c911184](c911184)) * add Identity workflow and Account Details page ([#2](#2)) ([7f86704](7f86704)) * add Lato font to UI ([#3](#3)) ([7b4e0f7](7b4e0f7))
alexs-mparticle
pushed a commit
that referenced
this pull request
Mar 30, 2022
# [1.1.0](v1.0.0...v1.1.0) (2022-03-29) ### Bug Fixes * Design Revisions ([#5](#5)) ([ec938af](ec938af)) ### Features * add Dialog to warn if API Key is missing ([#4](#4)) ([c911184](c911184)) * add Identity workflow and Account Details page ([#2](#2)) ([7f86704](7f86704)) * add Lato font to UI ([#3](#3)) ([7b4e0f7](7b4e0f7))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adjust padding and spacing around UI components and other design revisions/clean up