Fix for double URI component encoding when querying GiantBomb API #209
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me again 😅
I noticed that the Giantbomb API wasn't always returning results, even for things I knew were definitely in their database. Manually querying the API returned results as expected, so I did some digging.
It looks like
openapi-fetchencodes query parameters automatically, so the manual call toencodeURIComponentwas doubling up. For example, searching for "A Short Hike" generated this URL for the query:Whereas what we want (
%20for spaces, not%2520) is:Which is what gets generated with this little fix in place.