Skip to content

Fix underline position in error message #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix underline position in error message #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/parsers/ParsingError.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ export class ParsingValidationError extends MetaBindError {
return '';
}

const spacing = ' '.repeat(this.position.from.index + offset);
const spacing = ' '.repeat(this.position.from.column + offset);
// highlight to the end if the end is on the same line. If the end is on a different line, highlight to the end of the line.
const toIndex = this.position.to.line === this.position.from.line ? this.position.to.index : lineLength;
const underline = '^'.repeat(toIndex - this.position.from.index);
const toIndex = this.position.to.line === this.position.from.line ? this.position.to.column : lineLength;
const underline = '^'.repeat(toIndex - this.position.from.column);

return spacing + underline;
}
Expand Down