Skip to content

Conversation

@vblinden
Copy link
Contributor

See title

@maartenpaauw
Copy link
Owner

Thank you! Could you please update the test strategy as well?

See: https://github.com/maartenpaauw/laravel-specification-pattern/blob/develop/.github/workflows/run-tests.yml#L12-L23

@vblinden vblinden force-pushed the feature/laravel-10-support branch from e2530f0 to 7a9509a Compare March 21, 2023 08:12
@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Merging #7 (6eef6c2) into develop (be6fde8) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             develop        #7   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        30        30           
===========================================
  Files              8         8           
  Lines             69       107   +38     
===========================================
+ Hits              69       107   +38     

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@maartenpaauw maartenpaauw force-pushed the feature/laravel-10-support branch from 7a9509a to dcca054 Compare March 21, 2023 08:28
matrix:
os: [ubuntu-latest, windows-latest]
php: [8.0, 8.1]
laravel: [8.*, 9.*]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes were needed for this line too. I've updated it.

vblinden and others added 4 commits March 21, 2023 09:47
This is the earliest version where Carbon version 2.62.1+ is used, which is needed to work with PHP 8.2.
@maartenpaauw maartenpaauw merged commit 8953e7f into maartenpaauw:develop Mar 21, 2023
@vblinden vblinden deleted the feature/laravel-10-support branch March 31, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants