Skip to content

Conversation

@gfortaine
Copy link

@mac-s-g Many thanks for this great project. We are successfully using it in production. However, we have identified 2 minor bugs :

  • the AddKeyRequest component is masked when the initial JSON is empty and there is another ReactJson component below. So, a good compromise could be to set a min-height on the react-json-view container
  • when the value of a key is too long, after a click on it, it displays beyond the container. So, a good fix would be to use the word-break CSS property

@gfortaine
Copy link
Author

#240

@mac-s-g mac-s-g merged commit 46f0a72 into mac-s-g:master Jan 16, 2021
@mac-s-g
Copy link
Owner

mac-s-g commented Jan 16, 2021

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants