WX Monkey patch ClientDC for name changes

DrawRectangleRect has been renamed to DrawRectange. So we monkeypatch the new version to add the old version as an alias

Author: jenshnielsen

lib/matplotlib/backends/backend_wx.py

@@ -832,7 +832,7 @@ def gui_repaint(self, drawDC=None, origin='WX'):
         if self.IsShownOnScreen():
             if not drawDC:
                 # not called from OnPaint use a ClientDC
-                drawDC = wx.ClientDC(self)
+                drawDC = wxc.ClientDC(self)
 
             # ensure that canvas has no 'left' over stuff when resizing frame
             drawDC.Clear()
@@ -1687,7 +1687,7 @@ def release(self, event):
     def draw_rubberband(self, event, x0, y0, x1, y1):
         # Use an Overlay to draw a rubberband-like bounding box.
 
-        dc = wx.ClientDC(self.canvas)
+        dc = wxc.ClientDC(self.canvas)
         odc = wx.DCOverlay(self.wxoverlay, dc)
         odc.Clear()
 
@@ -1720,10 +1720,7 @@ def draw_rubberband(self, event, x0, y0, x1, y1):
         r, g, b, a = color.Get(True)
         color.Set(r, g, b, 0x60)
         dc.SetBrush(wx.Brush(color))
-        if wxc.is_phoenix:
-            dc.DrawRectangle(rect)
-        else:
-            dc.DrawRectangleRect(rect)
+        dc.DrawRectangleRect(rect)
 
     def set_status_bar(self, statbar):
         self.statbar = statbar

lib/matplotlib/backends/wx_compat.py

@@ -28,6 +28,9 @@
     print(" wxPython version %s was imported." % backend_version)
     raise ImportError(missingwx)
 
+# Import ClientCD so we can Monkey patch it.
+ClientDC = wx.ClientDC
+
 if is_phoenix:
     # define all the wxPython phoenix stuff
 
@@ -83,6 +86,8 @@
     NamedColour = wx.Colour
     StockCursor = wx.Cursor
 
+    # Moneypatch ClientDC to for rename of DrawRectangleRect to DrawRectangle
+    ClientDC.DrawRectangleRect = ClientDC.DrawRectangle
 else:
     # define all the wxPython classic stuff