Skip to content

Conversation

@ychin
Copy link
Member

@ychin ychin commented Jan 25, 2025

Only run the full suite of Vim tests when doing a tagged release. Otherwise just either run GUI or non-GUI test on each platform. This should catch most regressions in Vim upstream functionality, as even a bad upstream merge should still exhibit the same issue in one of the other (and most MacVim pull requests do not touch Vim to begin with). This helps speeds up CI as currently it's quite time consuming to run Vim tests twice.

We still run the whole thing for a release for now just to catch any potential issues.

Only run the full suite of Vim tests when doing a tagged release.
Otherwise just either run GUI or non-GUI test on each platform. This
should catch most regressions in Vim upstream functionality, as even a
bad upstream merge should still exhibit the same issue in one of the
other (and most MacVim pull requests do not touch Vim to begin with).
This helps speeds up CI as currently it's quite time consuming to run
Vim tests twice.

We still run the whole thing for a release for now just to catch any
potential issues.
@ychin ychin added Infrastructure Non-app infrastructure issues, e.g. CI Non User Facing Non-user facing change. These issues do no need to show up in release notes. labels Jan 25, 2025
@github-actions github-actions bot added the CI Vim upstream label for CI issues label Jan 25, 2025
@ychin ychin merged commit 8a68481 into macvim-dev:master Jan 25, 2025
4 checks passed
@ychin ychin deleted the ci-dont-run-gui-nongui-vim-tests branch January 25, 2025 09:04
@ychin ychin added this to the Release 181 milestone Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Vim upstream label for CI issues Infrastructure Non-app infrastructure issues, e.g. CI Non User Facing Non-user facing change. These issues do no need to show up in release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant