Skip to content

Conversation

@mglotov
Copy link
Contributor

@mglotov mglotov commented Oct 26, 2021

PR Description

We have a lot of Terraform modules used to create IAM roles where the trusted entity is a k8s cluster. However, this approach isn't useful because we don't re-use those modules. They are used just as static code.

I've deleted all individual modules and created a new one called aws-iam-eks-trusted. All calls of modules with aws-iam-... prefix were changed to use aws-iam-eks-trusted module and an IAM policy as a module input argument.

Fixes #137

Type of change

  • Documentation update
  • Code refactoring

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@mglotov mglotov requested review from a team, halfb00t and p1gmale0n October 26, 2021 05:32
@mglotov mglotov marked this pull request as ready for review October 26, 2021 05:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov merged commit d5400b0 into main Oct 26, 2021
@mglotov mglotov deleted the refactor/aws-iam-eks-trusted branch November 3, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aws-eks-iam] aws-iam-.. modules refactoring

4 participants