Skip to content

fix: removed this prefix from r53 and acm modules outputs #223 #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2021
Merged

fix: removed this prefix from r53 and acm modules outputs #223 #224

merged 1 commit into from
Nov 26, 2021

Conversation

@halfb00t
Copy link
Member

@halfb00t halfb00t commented Nov 25, 2021 •
edited
Loading

PR Description

Fixed acm and route53 modules outputs. Removed this_ prefix. Which was overlooked

Fixes #223

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 25, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@halfb00t halfb00t enabled auto-merge (squash) November 25, 2021 08:37
@halfb00t halfb00t requested review from a team, khalezin, mglotov and p1gmale0n November 25, 2021 08:38
@halfb00t halfb00t merged commit adddaae into main Nov 26, 2021
@halfb00t halfb00t deleted the fix/r53-acm-this branch November 26, 2021 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mglotov mglotov mglotov approved these changes

@khalezin khalezin Awaiting requested review from khalezin

@p1gmale0n p1gmale0n Awaiting requested review from p1gmale0n

+1 more reviewer

@cybertester cybertester cybertester approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: change route53 and acm modules outputs, remove this_ prefix

4 participants

@halfb00t @cybertester @mglotov