Skip to content

bug: allow external secrets to get secrets from AWS Secrets Manager #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2022
Merged

bug: allow external secrets to get secrets from AWS Secrets Manager #241

merged 1 commit into from
Jan 6, 2022

Conversation

@mglotov
Copy link
Contributor

@mglotov mglotov commented Jan 6, 2022 •
edited by khalezin
Loading

PR Description

These changes allow external-secrets pod to get secrets from AWS Secrets Manager

Fixes #231

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@mglotov mglotov requested review from a team, halfb00t, khalezin and p1gmale0n January 6, 2022 11:02
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mglotov mglotov merged commit b0b65c6 into main Jan 6, 2022
@mglotov mglotov deleted the bug-external-secret branch January 6, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@halfb00t halfb00t halfb00t approved these changes

@khalezin khalezin Awaiting requested review from khalezin

+1 more reviewer

@p1gmale0n p1gmale0n p1gmale0n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: external-secrets

4 participants

@mglotov @p1gmale0n @halfb00t